Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces pyreadr with rdata for reading .rds files, and aligns the project/tooling with a Python 3.11+ baseline.
Changes:
- Swap the RDS reader implementation from
pyreadrtordata, adding custom constructors forDateandPOSIXct(with NaN-aware conversions). - Add unit tests covering the new constructors and datetime type inference behavior.
- Bump minimum supported Python to 3.11 and update CI matrix/versioning accordingly.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tealflow_mcp/utils/dataset_readers.py |
Re-implements RDS loading via rdata, adds Date/POSIXct constructors and datetime type inference. |
tests/test_dataset_readers.py |
Adds tests for NaN-safe constructors and _infer_datetime_type. |
pyproject.toml |
Replaces pyreadr with rdata, bumps Python requirement to >=3.11, updates tooling targets. |
.github/workflows/ci.yml |
Updates CI Python versions to 3.11–3.13 and adjusts coverage run version. |
tealflow_mcp/__init__.py |
Version bump to 0.2.0.dev2. |
uv.lock |
Lockfile refresh reflecting dependency switch and Python version bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have you read the Contributing Guidelines?
Issue #
Description
Clear and concise description of what changed and why.
If necessary, include screenshots and/or a step-by-step guide on how to test the changes.
Definition of Done
R CMD check, linter, unit tests, spelling)..Rdfiles withroxygen2::roxygenise())